#604 Traceback on receiving <proceed/> before <starttls/>
Reporter
Zash
Owner
Nobody
Created
Updated
Stars
(0)
Tags
Priority-Medium
Type-Defect
Milestone-0.10
Status-Fixed
Zash
on
Triggered by experimenting with sending <starttls/> directly when opening the stream.
Real servers should not do this, but it would be nice to fix the traceback.
Should Prosody kill the connection for violating the protocol or happily go ahead with TLS?
s2soutfbb520 debug Received[s2sout_unauthed]: <proceed xmlns='urn:ietf:params:xml:ns:xmpp-tls'>
carcharodon.zash.se:tls debug Proceeding with TLS on s2sout...
socket debug server.lua: attempting to start tls on tcp{client}: 0xc89fe8
mod_s2s error Traceback[s2s]: /home/zash/.luarocks/share/lua/5.1/ssl.lua:120: bad argument #1 to 'create' (SSL:Context expected, got nil)
stack traceback:
[C]: in function 'create'
/home/zash/.luarocks/share/lua/5.1/ssl.lua:120: in function 'ssl_wrap'
./net/server_select.lua:616: in function 'starttls'
plugins/mod_tls.lua:129: in function <plugins/mod_tls.lua:126>
(tail call): ?
./util/events.lua:78: in function <./util/events.lua:74>
(tail call): ?
./core/stanza_router.lua:149: in function <./core/stanza_router.lua:56>
(tail call): ?
[C]: in function 'xpcall'
...
[C]: in function 'parse'
./util/xmppstream.lua:294: in function 'feed'
plugins/mod_s2s/mod_s2s.lua:556: in function 'data'
plugins/mod_s2s/mod_s2s.lua:604: in function <plugins/mod_s2s/mod_s2s.lua:601>
(tail call): ?
./net/server_select.lua:919: in function <./net/server_select.lua:894>
[C]: in function 'xpcall'
prosody:387: in function 'loop'
prosody:418: in main chunk
[C]: ?
Triggered by experimenting with sending <starttls/> directly when opening the stream. Real servers should not do this, but it would be nice to fix the traceback. Should Prosody kill the connection for violating the protocol or happily go ahead with TLS? s2soutfbb520 debug Received[s2sout_unauthed]: <proceed xmlns='urn:ietf:params:xml:ns:xmpp-tls'> carcharodon.zash.se:tls debug Proceeding with TLS on s2sout... socket debug server.lua: attempting to start tls on tcp{client}: 0xc89fe8 mod_s2s error Traceback[s2s]: /home/zash/.luarocks/share/lua/5.1/ssl.lua:120: bad argument #1 to 'create' (SSL:Context expected, got nil) stack traceback: [C]: in function 'create' /home/zash/.luarocks/share/lua/5.1/ssl.lua:120: in function 'ssl_wrap' ./net/server_select.lua:616: in function 'starttls' plugins/mod_tls.lua:129: in function <plugins/mod_tls.lua:126> (tail call): ? ./util/events.lua:78: in function <./util/events.lua:74> (tail call): ? ./core/stanza_router.lua:149: in function <./core/stanza_router.lua:56> (tail call): ? [C]: in function 'xpcall' ... [C]: in function 'parse' ./util/xmppstream.lua:294: in function 'feed' plugins/mod_s2s/mod_s2s.lua:556: in function 'data' plugins/mod_s2s/mod_s2s.lua:604: in function <plugins/mod_s2s/mod_s2s.lua:601> (tail call): ? ./net/server_select.lua:919: in function <./net/server_select.lua:894> [C]: in function 'xpcall' prosody:387: in function 'loop' prosody:418: in main chunk [C]: ?
Looks like the traceback should have been fixed by https://hg.prosody.im/trunk/rev/a2081d28bd22 Needs testing.
ChangesYeah the error should be unreachable now.
Changes