#690 User gets kicked from room if they block an occupant's room JID using mod_blocklist
Reporter
Zash
Owner
Zash
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Status-Fixed
Milestone-0.10
Type-Defect
Zash
on
What steps will reproduce the problem?
1. Block user in MUC
2. Blocked user sends you PM
What is the expected output?
Nothing happens.
What do you see instead?
You get kicked.
This is essentially the same as #384 but for mod_blocklist. When a message is blocked, an error reply is generated. This error reply triggers Prosodys MUC ghost prevention, kicking the user.
Zash
on
Changes
owner Zash
tags Status-Accepted Milestone-0.10
Zash
on
Perhaps the better solution would be to have the MUC itself handle blocking.
MattJ
on
Maybe we could return a non-MUC-kickable error if full_sessions[stanza.attr.to]? :)
Zash
on
How would you do that without revealing to the blocked entity that they are blocked? That's usually not desirable. Actually, why bounce messages at all?
What steps will reproduce the problem? 1. Block user in MUC 2. Blocked user sends you PM What is the expected output? Nothing happens. What do you see instead? You get kicked. This is essentially the same as #384 but for mod_blocklist. When a message is blocked, an error reply is generated. This error reply triggers Prosodys MUC ghost prevention, kicking the user.
Perhaps the better solution would be to have the MUC itself handle blocking.
Maybe we could return a non-MUC-kickable error if full_sessions[stanza.attr.to]? :)
How would you do that without revealing to the blocked entity that they are blocked? That's usually not desirable. Actually, why bounce messages at all?
Did what MattJ suggested in https://hg.prosody.im/0.10/rev/13dad833e821
Changes