#399 Let auth plugins set username

Reporter lancestout
Owner MattJ
Created
Updated
Stars ★ (1)
Tags
  • Status-Fixed
  • Milestone-0.12
  • Priority-Medium
  • Type-Enhancement
  1. lancestout on

    Right now the mechanism plugins set the username portion of JIDs, but some auth plugins need to override the user specified username based on credentials (eg, exchanging an OAuth token for a JID).

  2. Waqas on

    The SASL API does not provide enough flexibility to auth plugins here. The workaround until now has been rolling your own SASL object in the plugin, but this is a lot of boilerplate. An example is mod_auth_phpbb3, which does automatic username escaping: http://hg.prosody.im/prosody-modules/file/e8eebf281405/mod_auth_phpbb3/mod_auth_phpbb3.lua#l230

    Changes
    • tags Type-Enhancement Milestone-0.10 Status-Accepted
    • owner Waqas
  3. Zash on

    Changes
    • tag Priority-Medium
  4. Zash on

    I don't believe this will make it to 0.10, bumping milestone.

    Changes
    • tags Milestone-0.11
  5. MattJ on

    I think we already have this for EXTERNAL and ANONYMOUS, so we just need to add it to PLAIN and SCRAM? Is that all? In any case, bumping feature to 0.12 due to impending release.

    Changes
    • tags Milestone-0.11 Milestone-0.12
  6. MattJ on

    I believe this is solved since 57192cf193c7 for PLAIN and 9184bdda22be for SCRAM.

    Changes
    • owner Waqas MattJ
    • tags Status-Fixed

New comment

Not published. Used for spam prevention and optional update notifications.