#246 Accept partial submitted form in MUC room configuration
Reporter
i@grompe.org.ru
Owner
MattJ
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Type-Defect
Milestone-0.10
Status-Fixed
i@grompe.org.ru
on
Other servers (ejabberd, M-Link) usually accept partial submitted room config forms, and Prosody doesn't.
Example use case:
A bot could set the room to members-only without requesting the form and knowing about other values.
MattJ
on
Hmmmmm. If a field isn't included in the submitted form, what should that field's value be? The current value? The default value? As far as I'm aware the spec doesn't say anything about this.
i@grompe.org.ru
on
The current value, of course, in order to be useful.
MattJ
on
Yeah, I guessed you would say that :)
It certainly suits this use case, but it's not standardized as far as I'm aware - and in other form handling cases it's not quite obvious to say "the current value of course".
Other servers (ejabberd, M-Link) usually accept partial submitted room config forms, and Prosody doesn't. Example use case: A bot could set the room to members-only without requesting the form and knowing about other values.
Hmmmmm. If a field isn't included in the submitted form, what should that field's value be? The current value? The default value? As far as I'm aware the spec doesn't say anything about this.
The current value, of course, in order to be useful.
Yeah, I guessed you would say that :) It certainly suits this use case, but it's not standardized as far as I'm aware - and in other form handling cases it's not quite obvious to say "the current value of course".
http://mail.jabber.org/pipermail/standards/2012-July/026477.html
Fixed in http://hg.prosody.im/trunk/rev/db5d1a350cc7
Changes