#186 Add files' size limit option for Proxy65

Reporter maranda3985
Owner MattJ
Created
Updated
Stars ★★★★ (5)  
Tags
  • Difficulty-Medium
  • Type-Enhancement
  • Milestone-0.10
  • Priority-Medium
  • Status-WontFix
  1. maranda3985 on

    *Description of feature:* Add a configuration option where you can specify the max size of the files Proxy bytestreams service can intermediate for.

  2. MattJ on

    A bandwidth allowance per JID would probably be sensible.

    Changes
    • owner MattJ
    • tags Difficulty-Medium Type-Enhancement Status-Accepted
  3. MattJ on

    We're going to merge mod_limits into Prosody for 0.10, so we should make sure it works with proxy65.

    Changes
    • tags Milestone-0.10
  4. Zash on

    Changes
    • tag Priority-Medium
  5. Zash on

    I'm not sure this can be done without changes to the server backends.

  6. Zash on

    I'm not even sure what's supposed to be covered by this issue? Actually file sizes? Why would we limit that? And as mentioned above, transfer rate limits would require either fiddling with the net.server 'link' method or doing the shuffling between sockets in the module itself.

  7. Zash on

    I also don't think there's any sensible way to indicate to the user that they've exceeded a size limit. Just closing the connection would just look as a generic failure, which would be terrible UX.

  8. MattJ on

    I think the sensible thing to do here would not be to limit sizes, but transfer rate. Proxy65 is used for more than file transfer, as it's actually a bidirectional pipe, it can be used for any OOB data. Since it has a dedicated port, such limits could be applied outside of Prosody, e.g. using iptables. Therefore I'm closing this issue, though if someone cares enough then I'd consider a new issue about adding support for proxy65 to mod_limits, or about generic bandwidth limits in net.server, etc.

    Changes
    • tags Status-WontFix

New comment