#973 mod_csi_battery_saver: give priority to "sent" carbons
Reporter
Ge0rG
Owner
Nobody
Created
Updated
Stars
★ (1)
Tags
Type-Defect
Priority-Medium
Status-Fixed
Ge0rG
on
Right now, mod_csi_battery_saver will consider "sent" carbons as not important:
`if carbon and stanza_direction == "out" then return false; end`
Please remove this rule, as outgoing carbons have an important signaling feature to let your other client know that you have reacted to a message. At least Conversations and yaxim will use that to mark the respective contact as "read" and to remove (blinking) notifications from the OS.
Thilo Molitor (tmolitor)
on
It would be better to consider XEP0333 (chat markers) as important, too.
That way not only answering a message will remove the blinking but just reading it will remove the blinking, too.
I will change that if I find the time.
Right now, mod_csi_battery_saver will consider "sent" carbons as not important: `if carbon and stanza_direction == "out" then return false; end` Please remove this rule, as outgoing carbons have an important signaling feature to let your other client know that you have reacted to a message. At least Conversations and yaxim will use that to mark the respective contact as "read" and to remove (blinking) notifications from the OS.
It would be better to consider XEP0333 (chat markers) as important, too. That way not only answering a message will remove the blinking but just reading it will remove the blinking, too. I will change that if I find the time.
See my commit adding support for chat markers as well as considering outgoing stanzas as important (if they meet the usual body criteria): https://hg.prosody.im/prosody-modules/rev/d1aa5fc005f7