I can rework the patch to also allow blacklisting networks, but would like to see some feeback first, whether the patch is acceptable at all.
Hi. Sorry about the delay, I went and reviewed your patches but then forgot to post the feedback here.
The feature in itself is desirable.
Can you explain why undozerocompression() is needed?
The function in_network_list() has a loop. I believe we have some unwritten policy against that, so that should be in mod_register instead.
Also please run luacheck over the changed files, there are some style issues like inconsistent whitespace.
Thank you for reviewing my patch. No problem about the delay.
I made a new version at
It is against current tip and has the style issues removed.
undozerocompression() is required because otherwise toBits() is broken. It converts a zero compressed IPv6 address like ::1, where :: is equivalent to a variable number of zeroes into the full, uncompressed representation including all the zeroes, which is later converted to a bitstring.
I don't understand the problem with the loop. Checking whether an IP address is contained in a network is a useful functionality and so belongs into util/ip.lua...