#254 Provide muc#roomconfig_allowinvites in mod_muc plugin
Reporter
alsroot2
Owner
MattJ
Created
Updated
Stars
★ (1)
Tags
Priority-Medium
Status-WontFix
Patch
Type-Enhancement
alsroot2
on
*What steps will reproduce the problem?*
1. Use telepathy-gabble to connect to Prosody
gabble fails to create muc, see https://bugs.freedesktop.org/show_bug.cgi?id=37897 bug.
Actually, I'm not sure if it is a bug of Prosody or telepathy-gabble.
Any thought is it might be "fixed" on Prosody side
*What is the expected output? What do you see instead?*
Affected code is:
diff --git a/plugins/muc/muc.lib.lua b/plugins/muc/muc.lib.lua
index ff11bd6..7945005 100644
--- a/plugins/muc/muc.lib.lua
+++ b/plugins/muc/muc.lib.lua
@@ -608,6 +608,13 @@ function room_mt:get_form_layout()
type = 'boolean',
label = 'Make Room Members-Only?',
value = self:is_members_only()
+ },
+ -- Workaround for https://bugs.freedesktop.org/show_bug.cgi?id=37897
+ {
+ name = 'muc#roomconfig_allowinvites',
+ type = 'boolean',
+ label = 'Whether to Allow Occupants to Invite Others?',
+ value = false
}
});
end
Waqas
on
This will need a bit more work. You have successfully added the option to the room configuration dialog, but the setting isn't actually used or saved :)
I'm changing the issue type from Defect to Enhancement. I'll see about making this work properly when I get a moment (unless someone beats me to it).
Changes
tagsType-Defect Type-Enhancement Status-Accepted
owner Waqas
alsroot2
on
In fact, it is what telepathy-gabble is searching for, ie, after my "fix" I got telepathy-gabble working properly (properly means here that telepathy-gabble managed to start and do the rest of work, that does not relate to this feature, fine).
Is it possible to have some kind of stub in the way I did w/o implementing the whole feature (if I got it right) ?
Waqas
on
Changes
tags Milestone-0.9
MattJ
on
We're dropping this from 0.9 to prevent it blocking the (overdue) release.
Changes
tagsMilestone-0.9
Stephen Paul Weber
on
This would be a very nice feature. Currently I have to set everyone I invite to owner so that they can invite others who can invite people.
Tony
on
I had to temporarily disable the mod_muc_config_restrict module because uses were reporting they could not invite others to a MUC.
Zash
on
Changes
tags Patch
MattJ
on
I'm closing this issue.
With the adoption of XEP-0249 (Direct MUC Invitations) in clients, there is no way to prevent someone from inviting someone else to a room. Even without this XEP, someone could just send someone else the room address. Therefore offering a configuration option for this would be misleading.
If you want to restrict access to a room, we already have the members-only option. We also added a new config option that is similar, which allows a room owner to control whether members may add other users to the members list by inviting them.
On a final note, a client breaking because a server did not offer a specific option is in my opinion broken.
*What steps will reproduce the problem?* 1. Use telepathy-gabble to connect to Prosody gabble fails to create muc, see https://bugs.freedesktop.org/show_bug.cgi?id=37897 bug. Actually, I'm not sure if it is a bug of Prosody or telepathy-gabble. Any thought is it might be "fixed" on Prosody side *What is the expected output? What do you see instead?* Affected code is: diff --git a/plugins/muc/muc.lib.lua b/plugins/muc/muc.lib.lua index ff11bd6..7945005 100644 --- a/plugins/muc/muc.lib.lua +++ b/plugins/muc/muc.lib.lua @@ -608,6 +608,13 @@ function room_mt:get_form_layout() type = 'boolean', label = 'Make Room Members-Only?', value = self:is_members_only() + }, + -- Workaround for https://bugs.freedesktop.org/show_bug.cgi?id=37897 + { + name = 'muc#roomconfig_allowinvites', + type = 'boolean', + label = 'Whether to Allow Occupants to Invite Others?', + value = false } }); end
This will need a bit more work. You have successfully added the option to the room configuration dialog, but the setting isn't actually used or saved :) I'm changing the issue type from Defect to Enhancement. I'll see about making this work properly when I get a moment (unless someone beats me to it).
ChangesType-DefectType-Enhancement Status-AcceptedIn fact, it is what telepathy-gabble is searching for, ie, after my "fix" I got telepathy-gabble working properly (properly means here that telepathy-gabble managed to start and do the rest of work, that does not relate to this feature, fine). Is it possible to have some kind of stub in the way I did w/o implementing the whole feature (if I got it right) ?
We're dropping this from 0.9 to prevent it blocking the (overdue) release.
ChangesMilestone-0.9This would be a very nice feature. Currently I have to set everyone I invite to owner so that they can invite others who can invite people.
I had to temporarily disable the mod_muc_config_restrict module because uses were reporting they could not invite others to a MUC.
I'm closing this issue. With the adoption of XEP-0249 (Direct MUC Invitations) in clients, there is no way to prevent someone from inviting someone else to a room. Even without this XEP, someone could just send someone else the room address. Therefore offering a configuration option for this would be misleading. If you want to restrict access to a room, we already have the members-only option. We also added a new config option that is similar, which allows a room owner to control whether members may add other users to the members list by inviting them. On a final note, a client breaking because a server did not offer a specific option is in my opinion broken.
ChangesWaqasMattJ